3d model loading #60
Closed
3d model loading #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using assimp library to load 3d models
atar13
requested review from
Tyler-Lentz,
dmin12,
gilkeidar,
EddieJ03 and
jhparkt
might be causing Windows client not to build. for some reason I was converting it to c_str before
|
Confirmed to work on lab machines |
dmin12
approved these changes
May 1, 2024
all renderable items inherit from the renderable class to avoid redefining functionality they all share (translation, scaling)
also added some comments to clarify what each shader can and can't do
also mess with model shading a bit more
Tyler-Lentz
approved these changes
May 7, 2024
|
These commits got merged into #56 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
Modelclass which can load a model from a file. These formats are supported.Instructions for downloading models is on the README of this branch.
Texture loading is not working yet and needs further debugging.
The one blocker right now is making sure it compiles on Windows (lab and GitHub actions). I'm working on figuring this out but before then I'd like to get some thoughts on the code.
Originally I was going to write my own parser (take one from a tutorial or CSE167). However, it was getting a bit cumbersome and there were many model format variations that I had to handle. Instead, I opted to use the Assimp library to perform the model loading. It's been recommended by previous 125 groups to reduce the complexity of loading models.
5/4 Update:
This PR grew out of just loading models and has turned into loading materials and textures. I think once we are able to load the player model it should be merged.
- [ ] initial light sources(punting this to another PR)